Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Userland app for servomotor #558

Open
wants to merge 20 commits into
base: master
Choose a base branch
from

Conversation

inesmaria08
Copy link
Contributor

This pull request adds an app that provides a simple interface for controlling the angle of a vector of connected servomotors. (tock/tock#4126).

Files added:

  • apis/interface/servo/src/lib.rs
  • apis/interface/servo/src/Cargo.toml
  • exemples/servo.rs

Copy link
Contributor

@alexandruradovici alexandruradovici left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please add testung for the servo api.

apis/interface/servo/Cargo.toml Outdated Show resolved Hide resolved
apis/interface/servo/src/lib.rs Outdated Show resolved Hide resolved
apis/interface/servo/src/lib.rs Show resolved Hide resolved
unittest/src/fake/servo/mod.rs Outdated Show resolved Hide resolved
Copy link
Contributor

@alexandruradovici alexandruradovici left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, only a function name change.

apis/interface/servo/src/lib.rs Outdated Show resolved Hide resolved
apis/interface/servo/src/lib.rs Outdated Show resolved Hide resolved
apis/interface/servo/src/lib.rs Outdated Show resolved Hide resolved
apis/interface/servo/src/lib.rs Outdated Show resolved Hide resolved
apis/interface/servo/src/lib.rs Outdated Show resolved Hide resolved
apis/interface/servo/src/lib.rs Outdated Show resolved Hide resolved
jrvanwhy
jrvanwhy previously approved these changes Jan 21, 2025
Cargo.toml Outdated
@@ -36,6 +36,7 @@ libtock_i2c_master = { path = "apis/peripherals/i2c_master" }
libtock_i2c_master_slave = { path = "apis/peripherals/i2c_master_slave" }
libtock_key_value = { path = "apis/storage/key_value" }
libtock_leds = { path = "apis/interface/leds" }
libtock_servo = { path = "apis/interface/servo" }
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Put this into alphabetical order (between libtock_runtime and libtock_small_panic).

Cargo.toml Outdated
@@ -69,6 +70,7 @@ exclude = ["tock"]
members = [
"apis/interface/buttons",
"apis/interface/buzzer",
"apis/interface/servo",
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Similarly, move this between apis/interface/leds and apis/kernel/low_level_debug to put it into alphabetical order.

src/lib.rs Outdated
pub mod servo {
use libtock_servo as servo;
pub type Servo = servo::Servo<super::runtime::TockSyscalls>;
}
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Move this into alphabetical order as well.

@alexandruradovici
Copy link
Contributor

There seems to be a problem due to one of the denos that uses slint. @jrvanwhy should we update the rust version to 1.82 or somehow disable that demo?

@jrvanwhy
Copy link
Collaborator

There seems to be a problem due to one of the denos that uses slint. @jrvanwhy should we update the rust version to 1.82 or somehow disable that demo?

Lets just update Rust.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants